Jump to content

Module talk:Yesno: Difference between revisions

From Fifth Empire Wiki
+Comment: "Fixed."
Moved space test case to main test cases table
Line 85: Line 85:
| {{yesno|no|yes=no|no=yes}}
| {{yesno|no|yes=no|no=yes}}
| yes
| yes
|-
| {{#invoke:Yesno|yesno| no |no=no}}
| {{yesno| no |no=no}}
| no
|}
|}


Line 92: Line 96:


:Just needs to handle spaces in the params better. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 11:41, 2 March 2013 (UTC)
:Just needs to handle spaces in the params better. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 11:41, 2 March 2013 (UTC)
{| class="wikitable"
::Thanks. Fixed. I moved your test case to the table above. --[[User:Ori.livneh|Ori.livneh]] ([[User talk:Ori.livneh|talk]]) 05:58, 3 March 2013 (UTC)
! Module output
! Template output
! Expected
|-
| {{#invoke:Yesno|yesno| no |no=no}}
| {{yesno| no |no=no}}
| no
|}
::Thanks. Fixed. --[[User:Ori.livneh|Ori.livneh]] ([[User talk:Ori.livneh|talk]]) 05:58, 3 March 2013 (UTC)

Revision as of 06:01, 3 March 2013

Test Cases (via Template:Yesno/doc)
Module output Template output Expected
Script error: The module returned a function value. It is supposed to return an export table. yes yes
Script error: The module returned a function value. It is supposed to return an export table. yes yes
Script error: The module returned a function value. It is supposed to return an export table. yes yes
Script error: The module returned a function value. It is supposed to return an export table. yes yes
Script error: The module returned a function value. It is supposed to return an export table. (blank)
Script error: The module returned a function value. It is supposed to return an export table. (blank)
Script error: The module returned a function value. It is supposed to return an export table. (blank)
Script error: The module returned a function value. It is supposed to return an export table. (blank)
Script error: The module returned a function value. It is supposed to return an export table. yes yes
Script error: The module returned a function value. It is supposed to return an export table. bacon bacon
Script error: The module returned a function value. It is supposed to return an export table. ham ham
Script error: The module returned a function value. It is supposed to return an export table. eggs
Script error: The module returned a function value. It is supposed to return an export table. ham
Script error: The module returned a function value. It is supposed to return an export table. eggs
Script error: The module returned a function value. It is supposed to return an export table. sausage sausage
Script error: The module returned a function value. It is supposed to return an export table. cup-of-tea cup-of-tea
Script error: The module returned a function value. It is supposed to return an export table. bacon bacon
Script error: The module returned a function value. It is supposed to return an export table. cup-of-tea cup-of-tea
Script error: The module returned a function value. It is supposed to return an export table. no no
Script error: The module returned a function value. It is supposed to return an export table. yes yes
Script error: The module returned a function value. It is supposed to return an export table. no no

As you can see, the template does not behave exactly as its documentation claims it does. I was not sure which to regard as authoritative: the ideal or actual implementation. I ultimately went with the former. Removing and not any from the Lua code will make the module behave like exactly like the template.

--Ori.livneh (talk) 10:46, 28 February 2013 (UTC)

Just needs to handle spaces in the params better. -- WOSlinker (talk) 11:41, 2 March 2013 (UTC)
Thanks. Fixed. I moved your test case to the table above. --Ori.livneh (talk) 05:58, 3 March 2013 (UTC)