View source for Module talk:InfoboxImage

{{Permanently protected}}
{{talk header}}
{{User:MiszaBot/config
|archiveheader       = {{talkarchivenav}}
|maxarchivesize      = 75K
|counter             = 1
|minthreadsleft      = 10
|minthreadstoarchive = 2
|algo                = old(365d)
|archive             = Module talk:InfoboxImage/Archive %(counter)d
}}
{{archives|search=yes}}

== Template-protected edit request on 8 June 2021 ==

{{edit template-protected|Module:InfoboxImage|answered=yes}}
I would like to have Judge Rose's photo on her Wikipedia profile page updated. I'm passing this request along from Judge Rose herself. I have an updated photo from her that I can send to you but wanted to confirm that I'm in the right place to request this change. [[User:8thcirc|8thcirc]] ([[User talk:8thcirc|talk]]) 19:04, 8 June 2021 (UTC)
:{{to|8thcirc}} [[File:Red information icon with gradient background.svg|20px|link=|alt=]] '''Not done:''' this is the [[Help:Talk pages|talk page]] for discussing improvements to the page [[:Module:InfoboxImage]]. If possible, please make your request at the talk page for the article concerned. If you cannot edit the article's talk page, you can instead make your request at [[Wikipedia:Requests for page protection#Current requests for edits to a protected page]].<!-- Template:ETp --> '''''[[User:Paine Ellsworth|<span style="font-size:92%;color:darkblue;font-family:Segoe Script">P.I.&nbsp;Ellsworth</span>]]'''''&nbsp;&nbsp;[[Editor|<span style="color:black">ed.</span>]]&nbsp;[[User talk:Paine Ellsworth|<sup>put'r&nbsp;there</sup>]]&nbsp;<small>22:55, 8 June 2021 (UTC)</small>

== none options for link and alt ==

We should probably add none options for link and alt. It would be useful in places such as {{tl|archives}} but likely other non-infobox templates using this as well since this is the most versetile image handling template. --[[User:Trialpears|Trialpears]] ([[User talk:Trialpears|talk]]) 15:14, 11 August 2021 (UTC)
:Seems like a good idea. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 21:10, 11 August 2021 (UTC)

== Module breaks when there are multiple images on Wikidata ==

In a [https://en.wikipedia.org/w/index.php?title=ARIA_Music_Awards_of_2014&oldid=1029676267 recent edit] the Module broke because there were three different images set on Wikidata, and the Module tried interpreting them as one, which doesn't work. Is there a way to recognize this and use them all separately? ''-- [[User:Asartea|<span style="color:#ad0000;">Asartea</span>]] [[User Talk:Asartea|<span style="color:#ad0000;"><sup>Talk</sup></span>]] <sup>&#124;</sup> [[Special:Contributions/Asartea|<span style="color:#ad0000;"><sup>Contribs</sup></span>]]'' 15:49, 29 August 2021 (UTC)

== Module update ==

I've done some work in the sandbox. The original intent was to add an error category for when URL links are used for images, as currently it just returns an empty string. While working on the code I've also cleaned up the code, including:
* Consistent spaces
* Consistent usage of quotation marks
* Using table.param instead of table["param"]
* Reordering the placeholder_image table alphabatically
* Removing ";" from the end of lines as Lua does not use that.

I've replaced the following block of code at [[Module:InfoboxImage#L-144]]:
<syntaxhighlight lang="lua">
    if mw.ustring.lower(mw.ustring.sub(image,1,5)) == "http:" then
        return "";
    end
    if mw.ustring.lower(mw.ustring.sub(image,1,6)) == "[http:" then
        return "";
    end
    if mw.ustring.lower(mw.ustring.sub(image,1,7)) == "[[http:" then
        return "";
    end
    if mw.ustring.lower(mw.ustring.sub(image,1,6)) == "https:" then
        return "";
    end
    if mw.ustring.lower(mw.ustring.sub(image,1,7)) == "[https:" then
        return "";
    end
    if mw.ustring.lower(mw.ustring.sub(image,1,8)) == "[[https:" then
        return "";
    end
</syntaxhighlight>

with [[Module:InfoboxImage/sandbox#L-137]]:

<syntaxhighlight lang="lua">
	if string.find(image, "^%[*http") then
		-- Error category.
		return "[[Category:Pages using infoboxes with url links]]"
	end
</syntaxhighlight>

I've added URL testcases to [[Module:InfoboxImage/testcases]]. The new tests and all previous tests pass [[Module talk:InfoboxImage/testcases]].

Please let me know if you have comments or questions. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 09:04, 2 October 2021 (UTC)
:There are [//commons.wikimedia.org/wiki/Special:AllPages?from=http&to=&namespace=6  quite a few] images at commons whose names begin with the letters "http". Will this code drop them into the error category? Perhaps "^%[*https?:" would be safer, if that's the correct regex syntax for string.find -- [[User:John of Reading|John of Reading]] ([[User talk:John of Reading|talk]]) 09:21, 2 October 2021 (UTC)
::I've added a test for an image from commons that starts with HTTP and it worked. That said I've also now updated the sandbox with your suggested code to make it more correct. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 09:35, 2 October 2021 (UTC)

== Why is "alt" the fallback for "title"? ==

In this condition
<syntaxhighlight lang="lua" line start="269">
if title ~= "" and title ~= nil then
    result = result .. "|" .. title;
elseif alt ~= "" and alt ~= nil then
    result = result .. "|" .. alt;
end
</syntaxhighlight>
{{para|alt}} is used as the fallback for an image title when {{para|title}} is not present. This appears arbitrary to me and it diverges from the usual behavior of {{para|alt}} in [[File:]] constructs. As a result, articles that use InfoboxImage and alt (but not title) for each image suddenly have a title on the infobox image, but none on all others. Is there a reason that this is the case? Can this behavior be corrected (by removing lines 271 and 272)? [[User:IceWelder|<span style="font-variant: small-caps;">IceWelder</span>]] &#91;[[User talk:IceWelder|<span style="color: #424242;">&#9993;</span>]]&#93; 07:38, 26 October 2021 (UTC)
: Not sure whether anyone is even watching this talk page. {{Ping|WOSlinker}} You're the most active editor on the module. Would you mind sharing your insight? [[User:IceWelder|<span style="font-variant: small-caps;">IceWelder</span>]] &#91;[[User talk:IceWelder|<span style="color: #424242;">&#9993;</span>]]&#93; 17:22, 27 October 2021 (UTC)
:: It was just done that way so that the hover over tooltip showed some information. If there are no objections in the next week then I'll remove it. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 18:29, 27 October 2021 (UTC)
::: I've updated it. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 18:26, 5 November 2021 (UTC)
:::: I made this corresponding doc update https://en.wikipedia.org/w/index.php?title=Module:InfoboxImage/doc&type=revision&diff=1065533441&oldid=1048551125&diffmode=source Note that lines 259-262 now seem redundant <syntaxhighlight lang="lua">
        -- if alt value is a keyword then do not use as a description
        if alt == "thumbnail" or alt == "thumb" or alt == "frameless" or alt == "left" or alt == "center" or alt == "right" or alt == "upright" or alt == "border" or mw.ustring.match(alt or "", '^[0-9]*px$', 1) ~= nil then
            alt = nil;
        end
</syntaxhighlight> [[User:Arlolra|Arlolra]] ([[User talk:Arlolra|talk]]) 01:58, 14 January 2022 (UTC)

== Template-protected edit request on 8 March 2022 ==

{{tper|ans=yes}}
<div class="thumb tright"><div class="thumbinner">{{#invoke:InfoboxImage/sandbox|InfoboxImage |image=Mustela erminea upright.jpg |upright=0.5|class=nopageimage}}</div></div>
Please apply the changes made to the module in [[Module:InfoboxImage/sandbox]] ({{Compare pages|{{SUBJECTPAGENAME}}|{{SUBJECTPAGENAME}}/sandbox|diff}}), which adds the option for a "class" parameter that allows upper templates to set an [[Help:Images#Syntax|HTML class]] for the infobox image (particularly the newly-introduced [[mw:Extension:PageImages#Can I exclude certain page images?|"notpageimage" class]], which removes the image from the list of page images). Testcase of working usage of the parameter is shown at the right side (you may need to use the browser's element inspector to verify that the class exists). <span style="background:#ffff55">'''''[[User:Chlod|Chlod]]'''''</span>&nbsp;<small style="font-size:calc(1em - 2pt)">([[User talk:Chlod|say&nbsp;hi!]])</small> 09:47, 8 March 2022 (UTC)
:{{done}} -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 19:18, 13 March 2022 (UTC)
:{{U|Chlod}} I think it would make more sense for this module to provide an API to add the class(es) of interest rather than to provide a class parameter that we'll have to chase the name down should the name ever change. (Or for any other reason.) [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 03:25, 14 March 2022 (UTC)

== Help with improving default image sizes  ==

A few editors had a contentious but thoughtful discussion about default image sizes in infoboxes that fizzled out due to lack of technical expertise; see [[Template_talk:Infobox_bridge/Archive_2#Image_and_map_widths|this discussion]] from July 2022. It looks like the next step was to post a request for help here. Basically, we thought that this module might be able to do a better job of providing images for infoboxes that followed editors' thumb size preferences so that we could move away from fixed pixel size specifications in infoboxes. If there is anyone here who is willing to look into how we might default to <code>frameless</code> (or whether the module already does this, and how to code infobox image calls properly), I would be grateful. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 01:03, 10 January 2023 (UTC)

Ditto. On some other wikis you format the image inside the info box, and can just use 'upright' to size, but on WP-en it's too complicated for me to figure out. It would be nice if at e.g. the language infobox we could set the default to, say, upright=0.9, and editors could override with their own upright value if they chose.

Is it possible to set the infobox width to match the user's default image size, or would that be a bad idea? [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 01:45, 10 January 2023 (UTC)

:Perhaps I am misunderstanding the discussion or request. There is already a parameter {{para|upright}} to this Module, which is passed along to the <nowiki>[[Image:XXX]]</nowiki> wikitext. If you want an infobox image to default to 114% of the size of a user's preference, why not just set {{para|upright|1.14}} in the infobox code? What am I missing? — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 03:51, 10 January 2023 (UTC)
::In my case, that I don't know what I'm doing with this module! [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 03:53, 10 January 2023 (UTC)
:::Is there a specific infobox we can try to improve? Maybe that will make things clearer (or maybe there will an unanticipated problem and we'll learn from the attempt). — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 03:55, 10 January 2023 (UTC)
::::Yes, thank you. {{tl|Infobox language}}, which I could then extend to Infobox language family. [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 03:57, 10 January 2023 (UTC)
:::::Is the idea to default to {{para|upright|0.9}} (~200/220) ? Let's try it in the sandbox. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 03:58, 10 January 2023 (UTC)
::::::Currently, 'image' is set to 90% and 'map' to 100%. [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 03:59, 10 January 2023 (UTC)
:::::::Looks like it worked, see [[Template:Infobox language/testcases]]. My default image size is 250px, and it clearly changed for me. It still allows fixed-size overriding, but the default will obey user preferences. Hopefully this will resolve the dispute that seemed to happen at [[Template talk:Infobox bridge/Archive 2]]? 
:::::::I'll leave it to other editors to get consensus on this change, but it seems to work technically. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 04:07, 10 January 2023 (UTC)
::::::::Thanks! 
::::::::Would it be possible to set it so that if we enter, say, 'mapsize' or 'imagesize=1.25', it will set it as upright=1.25, so we don't have to use px? [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 04:18, 10 January 2023 (UTC)
:::::::::I guess we could check to see if the mapsize is <4, use it as upright? I worry that this will be confusing to editors. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 05:56, 10 January 2023 (UTC)
It looks like using {{para|upright}} will generally work, as shown at [[Template:Infobox bridge/testcases]] (set your thumbnail preference to 300px or higher to see the difference). Somewhere (I forget where, unfortunately), an editor chose to specify an infobox image size to match the pixel size of the mapframe map in the infobox. I don't see a way to apply {{para|upright}} to mapframe maps, so I posted a query [[Template_talk:Infobox_mapframe#How_can_we_scale_the_map_size_to_the_reader's_thumbnail_preference?|at the relevant talk page]]. – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 05:04, 10 January 2023 (UTC)

:Anything other than a number in mapsize gives the same output, ~ equivalent to entering 500. [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 06:25, 10 January 2023 (UTC)
:I've changed the infobox, checking articles. No problems so far. [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 06:26, 10 January 2023 (UTC)
:I don't see how |upright= has any effect on anything. [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 06:29, 10 January 2023 (UTC)
::{{ping|Kwamikagami}} Have you tried changing your preference for thumbnail size away from 220px? — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 07:09, 10 January 2023 (UTC)
:::No, but I would think that setting upright=2 would be visible regardless. [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 07:11, 10 January 2023 (UTC)
::::Oh, I bet I know what this is. This is a limitation in MediaWiki. If you start with a tiny image, it won't blow it up larger than its actual size. What's the example of upright not working? — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 07:14, 10 January 2023 (UTC)
:::::I see that at e.g. [[Malay language]], where the map is an SVG but the nominal size is only 257×190px. And indeed, the English map has a nominal size of 512×260px, which is probably what I was getting when I set the size to anything but a number. But the map at [[Arabic language]] is nominally 1200px, and 'upright' has no effect there either (neither map nor image). [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 07:20, 10 January 2023 (UTC)
::::::I'm a bit confused. [[:File:Arabic albayancalligraphy.svg]] (the example image in the infobox) is 343px, so it won't get bigger than that. [[:File:Arabic speaking world.svg]] is 1200px, but {{para|upright}} appears to work (see below). — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 07:30, 10 January 2023 (UTC)
:::::::Yeah, looks fine here, but no effect in the infobox. I just saved a test edit on that page, in case the preview wasn't working: nothing. [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 07:37, 10 January 2023 (UTC)
{{#invoke:InfoboxImage|InfoboxImage|image=File:Arabic speaking world.svg|upright=0.7}}
{{#invoke:InfoboxImage|InfoboxImage|image=File:Arabic speaking world.svg|upright=2}}
::::::::I think there was a misunderstanding. I didn't implement {{para|upright}} in {{tl|Infobox language}}: I just made the default have scalable thumbnails. In [[Template:Infobox language/sandbox]] I implemented {{para|imageupright}} and {{para|mapupright}} to work as you would think, see [[Template:Infobox language/testcases#Test upright]] for the results. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 09:43, 10 January 2023 (UTC)

:Ah, thank you. Yes, that works beautifully. 
:I changed the labels to 'imagescale' and 'mapscale', as there's been some confusion that 'upright' is only used will tall images. [[User:Kwamikagami|— kwami]] ([[User talk:Kwamikagami|talk]]) 10:39, 10 January 2023 (UTC)

== Updated strip marker ==

According to [[:mw:Strip marker]], the code for strip markers has changed. You need to replicate [https://ro.wikipedia.org/w/index.php?title=Modul%3AInfoboxImage&diff=15937108&oldid=10663380 this change] in order to get that code to work again. [[User:Strainu|Strainu]] ([[User talk:Strainu|talk]]) 20:58, 20 November 2023 (UTC)
:Implemented in the [[Module:InfoboxImage/sandbox]], but none of the existing tests failed. What is this change supposed to accomplish? Is there a test case where the old code fails and the new one succeeds?  — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 01:15, 21 November 2023 (UTC)
::Yes, the change is supposed to allow {{tl|Multiple images}} to be used with InfoboxImage: see the infobox at [[:ro:Târgoviște]]. From what I can see, [[Template:Multiple images]] has the same implementation as on rowiki, so it's very likely to fail with the old implementation. [[User:Strainu|Strainu]] ([[User talk:Strainu|talk]]) 08:11, 21 November 2023 (UTC)
:::Lines 178-180 already handle the updated format.  It's just that lines 175-178 were not updated previously. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 09:31, 21 November 2023 (UTC)
::::Is it safe to simply delete lines 175-177? — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 12:32, 21 November 2023 (UTC)
:::::Either would work, so I've applied the sandbox change and removed the other check. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 13:27, 21 November 2023 (UTC)
::::::Added a test case using {{tl|Multiple images}} (although it was not failing previously). — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 19:42, 21 November 2023 (UTC)

== Explicit option to not add image ==

This module is sometimes called by an infobox which passes on an image parameter if it's given in the call and otherwise automatically passes on a Wikidata image. If an article explicitly wants no image then it can pick one of the suppressed image names like <code>image=No image available.png</code> in [https://en.wikipedia.org/w/index.php?title=Batak_Hydropower_Cascade&diff=prev&oldid=1187688731] which uses {{tl|Infobox dam}}. That was hard to work out, later editors of the article may blank the bad looking image parameter in good faith, and I don't know whether the list of suppressed images is certain to never remove a listed image name. I suggest adding a clear and simple value <code>|image=no</code> to not display any image. A blank <code>|image=</code> already does this but as mentioned, that doesn't work in some calls of infoboxes. I came here after working on [[Wikipedia:Teahouse#Technical question about infobox]]. [[User:PrimeHunter|PrimeHunter]] ([[User talk:PrimeHunter|talk]]) 12:09, 1 December 2023 (UTC)

:Should all instances of a nested {{tl|Infobox dam}} disable the image? If so, the fix is straightforward in that template. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 12:21, 1 December 2023 (UTC)

== Tracking category for URLs in image field ==

Discussion: [[Template_talk:Infobox#URLs_in_image_field]]

There are probably thousands of URLs in the {{para|image}} field. Would it be possible to add a tracking category? They should be removed on a regular basis and tracking them would be a big help.  -- [[User:GreenC|<span style="color: #006A4E;">'''Green'''</span>]][[User talk:GreenC|<span style="color: #093;">'''C'''</span>]] 20:49, 19 July 2024 (UTC)

:Just need to update lines 146, 149, 152, 155, 158 & 161 to return a category. What do you want to call the category? -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 21:33, 19 July 2024 (UTC)
::Does infobox emit tracking categories anywhere else? Following CS1|2 naming, [[:Category:CS1_errors:_archive-url]], it might be [[:Category:Infobox_errors:_image]] a holding cell for all errors related to this module. -- [[User:GreenC|<span style="color: #006A4E;">'''Green'''</span>]][[User talk:GreenC|<span style="color: #093;">'''C'''</span>]] 23:31, 19 July 2024 (UTC)
:::It only emits [[:Category:Pages using infoboxes with thumbnail images]] at the moment. -- [[User:WOSlinker|WOSlinker]] ([[User talk:WOSlinker|talk]]) 06:19, 20 July 2024 (UTC)
::::That's a standard error category format. I would suggest [[:Category:Pages using infoboxes with URL in image field]]. — [[User:Hike395|hike395]] ([[User talk:Hike395|talk]]) 12:03, 20 July 2024 (UTC)
:::::Let's use the word "parameter" instead of "field", since that is the term here on Wikipedia, or just leave off the last word entirely: "Pages using infoboxes with URL in image". – [[User:Jonesey95|Jonesey95]] ([[User talk:Jonesey95|talk]]) 13:52, 20 July 2024 (UTC)
:Done: [[Special:Diff/1186186161/1236046032]] for [[:Category:Pages using infoboxes with URL in image parameter]] - I included "parameter" or it could be ambiguous, such as a URL displayed ''in'' the image, which might be a concern due to spam. -- [[User:GreenC|<span style="color: #006A4E;">'''Green'''</span>]][[User talk:GreenC|<span style="color: #093;">'''C'''</span>]] 16:02, 22 July 2024 (UTC)
::There are currently around 1.1k pages in the category. A bot can easily remove the usages. I wonder if a bot could also upload the image from the file and set it (if we want to use those images). Checking each page individually, seems tedious for something that no one cared to fix until now. [[User:Gonnym|Gonnym]] ([[User talk:Gonnym|talk]]) 13:34, 7 August 2024 (UTC)
:::Uploading images (automatically) is impossible due to copyright and descriptive issues. Simply deleting any URL found in the field is the correct action. The deletion is easy, the harder aspect is what the parameter names are to target. There are so many variations.  -- [[User:GreenC|<span style="color: #006A4E;">'''Green'''</span>]][[User talk:GreenC|<span style="color: #093;">'''C'''</span>]] 14:17, 7 August 2024 (UTC)
::::If it's a good-faith, but malformed, attempt to bring in an existing image hosted on Commons or English Wikipedia, such as <syntaxhighlight lang=wikitext>|image=https://en.wikipedia.org/wiki/File:Example.jpg</syntaxhighlight> or <syntaxhighlight lang=wikitext>|image=https://upload.wikimedia.org/wikipedia/en/a/a9/Example.jpg</syntaxhighlight> I think we should not delete the link outright, but fix it up as in <syntaxhighlight lang=wikitext>|image=Example.jpg</syntaxhighlight> with preview before save to ensure that it's a suitable image for the context. --[[User:Redrose64|<span style="color:#a80000; background:#ffeeee; text-decoration:inherit">Red</span>rose64]] &#x1f339; ([[User talk:Redrose64|talk]]) 20:52, 7 August 2024 (UTC)